Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wdspec] browsing_context/print: add IDs to background tests and format #40421

Merged
merged 1 commit into from
Jun 14, 2023
Merged

[wdspec] browsing_context/print: add IDs to background tests and format #40421

merged 1 commit into from
Jun 14, 2023

Conversation

thiagowfx
Copy link
Member

@thiagowfx thiagowfx commented Jun 7, 2023 •
edited
Loading

See commit history for explanations.

Chrome Print to PDF does not support tiny dimensions (c.f.
https://crbug.com/1430696).

The background test should not exercise dimensions testing. Instead, it
should be concerned merely with the background property.

With this change:

  • background.py passes in chrome bidi
  • newly added page.py tests (moved from background.py) still do not pass in chrome bidi

@thiagowfx thiagowfx force-pushed the thiagowfx/print branch 2 times, most recently from 41ef619 to 7df56cb Compare June 7, 2023 15:55
@thiagowfx thiagowfx changed the title print: add type annotations [wdspec] print: background tests should not exercise dimensions Jun 7, 2023
@thiagowfx thiagowfx marked this pull request as ready for review June 7, 2023 16:07
@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/bsytJJYmRfmM1F1qjsX8Nw/VLhyVbTxScOtPDok-vqlZw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/bsytJJYmRfmM1F1qjsX8Nw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/bsytJJYmRfmM1F1qjsX8Nw/VLhyVbTxScOtPDok-vqlZw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/bsytJJYmRfmM1F1qjsX8Nw"
      ]
    }
  ]
}
  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-06-07T18:32:24.353Z

@thiagowfx thiagowfx enabled auto-merge (squash) June 7, 2023 18:32
@thiagowfx thiagowfx closed this Jun 7, 2023
auto-merge was automatically disabled June 7, 2023 19:07

Pull request was closed

@thiagowfx thiagowfx reopened this Jun 7, 2023
@thiagowfx
Copy link
Member Author

Re-triggering run (close + reopen)

@thiagowfx thiagowfx enabled auto-merge (squash) June 7, 2023 19:07
whimboo
whimboo previously requested changes Jun 8, 2023
View reviewed changes
webdriver/tests/bidi/browsing_context/print/background.py Outdated Show resolved Hide resolved
webdriver/tests/support/image.py Outdated Show resolved Hide resolved
@thiagowfx thiagowfx requested a review from whimboo June 9, 2023 10:15
@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/FoB7UR5BRGeqmfe8J5VnGg/EXnfHoqFQNiAOLNa8fSoxQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/FoB7UR5BRGeqmfe8J5VnGg"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/FoB7UR5BRGeqmfe8J5VnGg/EXnfHoqFQNiAOLNa8fSoxQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/FoB7UR5BRGeqmfe8J5VnGg"
      ]
    }
  ]
}
  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-06-09T12:14:37.724Z

@thiagowfx
Copy link
Member Author

I'd appreciate pointers on why https://github.com/web-platform-tests/wpt/pull/40421/checks?check_run_id=14132619502 is failing. It's not really obvious from the log, and it seems to be a false positive.

I don't know why but this 'Community-TC' thing is often slow and seemingly flaky. I wonder if it's related to #31499

@thiagowfx thiagowfx mentioned this pull request Jun 9, 2023
Open
@thiagowfx
Copy link
Member Author

Moved the pre-factoring changes to a dedicated PR: #40470

The intent is to try to circumvent the failures in community-tc (c.f. #38450 (comment)) as they are unrelated

@thiagowfx
Copy link
Member Author

thiagowfx commented Jun 9, 2023 •
edited
Loading

Indeed...if we do not touch files in /support, then everything (in Chrome) works great.

@thiagowfx
Copy link
Member Author

thiagowfx commented Jun 9, 2023 •
edited
Loading

Now the chrome tests are not failing however there's something wrong with the firefox ones: https://community-tc.services.mozilla.com/tasks/HciShpGSQdmcAAw3BsfAlg/runs/0/logs/public/logs/live.log

@whimboo What would be the issue?

@whimboo
Copy link
Contributor

whimboo commented Jun 12, 2023

When you check the lines earlier in this log you can see that the test webdriver/tests/bidi/browsing_context/print/background.py is now failing with Firefox. I can also reproduce that locally when running ./wpt run firefox webdriver/tests/bidi/browsing_context/print/background.py --binary <path-to-firefox> --no-headless

@thiagowfx
Copy link
Member Author

@whimboo Thanks for the CLI, I can also reproduce it locally!

@thiagowfx thiagowfx disabled auto-merge June 13, 2023 13:37
@thiagowfx thiagowfx force-pushed the thiagowfx/print branch 3 times, most recently from f727993 to d9230d5 Compare June 13, 2023 13:38
@thiagowfx
Copy link
Member Author

We ended up fixing this in our end: GoogleChromeLabs/chromium-bidi#841

So it turns out this PR is not necessary anymore. I'll just convert it to do some formatting changes and add IDs to the tests.

@thiagowfx thiagowfx force-pushed the thiagowfx/print branch 2 times, most recently from 0b25d0f to 19b2ae8 Compare June 13, 2023 13:44
@thiagowfx thiagowfx changed the title [wdspec] print: background tests should not exercise dimensions [wdspec] browsing_context/print: add IDs to background tests and format Jun 13, 2023
@thiagowfx thiagowfx enabled auto-merge (squash) June 13, 2023 13:45
@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/fruYKeEwTBansKe2EPjoMQ/Ma0kZlT5QjuhHao89uFyHg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/fruYKeEwTBansKe2EPjoMQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/fruYKeEwTBansKe2EPjoMQ/Ma0kZlT5QjuhHao89uFyHg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/fruYKeEwTBansKe2EPjoMQ"
      ]
    }
  ]
}
  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-06-13T17:11:21.243Z

@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/fruYKeEwTBansKe2EPjoMQ/ChRw5oOvSWSBLUA_eYmpkg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/fruYKeEwTBansKe2EPjoMQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/fruYKeEwTBansKe2EPjoMQ/ChRw5oOvSWSBLUA_eYmpkg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/fruYKeEwTBansKe2EPjoMQ"
      ]
    }
  ]
}
  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-06-13T17:11:21.561Z

@thiagowfx
Copy link
Member Author

@whimboo this PR is very simple at this point, but wpt-firefox-nightly-stability fails.

Logs: https://community-tc.services.mozilla.com/tasks/Oqrpk1OLS_md0LKawxwEug/runs/0/logs/public/logs/live.log

All background.py and page.py tests are passing. Could you help me out to figure out the error this time?

whimboo
whimboo approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the flakiness is here but I mentioned it to @jgraham. As it looks like quite a few of other PRs are affected as well. I don't think that this is related to those changes given that wpt.fyi results and the nightly results are looking fine.

@jgraham can you please admin merge?

@jgraham jgraham disabled auto-merge June 14, 2023 08:41
@jgraham jgraham merged commit 6a3e640 into master Jun 14, 2023
@jgraham jgraham deleted the thiagowfx/print branch June 14, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadym-chromium sadym-chromium sadym-chromium approved these changes

@whimboo whimboo whimboo approved these changes

@foolip foolip Awaiting requested review from foolip

@AutomatedTester AutomatedTester Awaiting requested review from AutomatedTester

@jgraham jgraham Awaiting requested review from jgraham

@jrandolf-2 jrandolf-2 Awaiting requested review from jrandolf-2

@juliandescottes juliandescottes Awaiting requested review from juliandescottes

@shs96c shs96c Awaiting requested review from shs96c

Assignees

@foolip foolip

@juliandescottes juliandescottes

@sadym-chromium sadym-chromium

Labels
webdriver webdriver-bidi wg-testing_browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@thiagowfx @whimboo @sadym-chromium @jgraham @foolip @juliandescottes @wpt-pr-bot